[PATCH] D38722: Added Remarks for Loop Versioning LICM Pass

[Evgeny Astigeevich via Phabricator via llvm-commits]

eastig added a comment.

The patch looks OK to me if using std::to_string is allowed now.



================
Comment at: lib/IR/DiagnosticInfo.cpp:171
+DiagnosticInfoOptimizationBase::Argument::Argument(StringRef Key, float N)
+    : Key(Key), Val(std::to_string(N)) {} 
 
----------------
There were some build issues with std::to_string especially with old gcc versions. I don't know if all of them have been fixed. There is llvm::to_string to work around the issues. 


Repository:
  rL LLVM

https://reviews.llvm.org/D38722