[PATCH] D41864: DBG_VALUE insertion for spills breaks bundles
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 9 08:52:53 PST 2018
aprantl added inline comments.
================
Comment at: lib/CodeGen/LiveDebugValues.cpp:676
+ for (auto &SP : Spills){
+ MachineInstr *InsertPoint = SP.SpillInst;
+ MachineInstr *DebugInst = SP.DebugInst;
----------------
If there is really no way to test this with in-tree targets, we should at the very least have a detailed comment here explaining why this is implemented this way. Could you please add a comment that explains the rationale like in the review description here?
Repository:
rL LLVM
https://reviews.llvm.org/D41864
More information about the llvm-commits
mailing list