[PATCH] D41851: X86 Tests: Update more isel tests with FastVariableShuffle feature

[Zvi Rackover via Phabricator via llvm-commits]

zvi added inline comments.


================
Comment at: test/CodeGen/X86/avx2-conversions.ll:5
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2 | FileCheck %s --check-prefixes=X64,X64-SLOW
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2,+fast-variable-shuffle | FileCheck %s --check-prefixes=X64-FAST
 
----------------
RKSimon wrote:
> --check-prefixes=X64,X64-FAST
thanks


================
Comment at: test/CodeGen/X86/psubus.ll:6
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx | FileCheck %s --check-prefixes=AVX,AVX1
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2 | FileCheck %s -check-prefixes=AVX,AVX2,AVX2-SLOW
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2,+fast-variable-shuffle | FileCheck %s --check-prefixes=AVX,AVX2,AVX2-FAST
----------------
RKSimon wrote:
> --check-prefixes=AVX,AVX2,AVX2-SLOW
Good catch thanks


================
Comment at: test/CodeGen/X86/psubus.ll:8
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2,+fast-variable-shuffle | FileCheck %s --check-prefixes=AVX,AVX2,AVX2-FAST
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512bw,+avx512vl,+fast-variable-shuffle | FileCheck %s --check-prefixes=AVX,AVX512
 
----------------
RKSimon wrote:
> Possibly do the prefix cleanup as separate commit straight away?
Ok


https://reviews.llvm.org/D41851