[PATCH] D41855: [ARM] Fix erroneous availability of SMMLS for Armv7-M

[Andre Vieira via Phabricator via llvm-commits]

avieira added inline comments.


================
Comment at: test/CodeGen/ARM/smml.ll:2
 ; RUN: llc -mtriple=arm-eabi %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=CHECK-V4
-; RUN: llc -mtriple=armv6-eabi %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=CHECK-V6
+; RUN: llc -mtriple=armv6t2-eabi %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=CHECK-V6
 ; RUN: llc -mtriple=armv7-eabi %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=CHECK-V6
----------------
avieira wrote:
> samparker wrote:
> > This duplicates line 6, and why remove the v6 triple? And what about a test that ensures v7E-M works?
> It does indeed, didnt see it. As for v7E-M... that was in the other patch, Ill add one here too. Thanks.
Right, I was missing my coffee ... line 2 and 6 are for arm and thumb mode respectively. I had another look at the ARM ARM and for arm mode, v6 accepts SMMLS, for thumb only  v6T2 accepts it.

I see in ARM.td that FeatureDSP was only added to armv6t2. I have now added it to Armv6.


https://reviews.llvm.org/D41855