[PATCH] D41610: [X86] Implementation of X86Operand::print

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

A couple of minors, but no more comments from me. @craig.topper ?



================
Comment at: lib/Target/X86/AsmParser/X86Operand.h:102
+
+    auto printImmValue = [&](const MCExpr *Val, const char *VName) {
+      if (Val->getKind() == MCExpr::Constant) {
----------------
Capitalization: PrintImmValue


================
Comment at: lib/Target/X86/AsmParser/X86Operand.h:107
+      } else {
+        assert(Val->getKind() == MCExpr::SymbolRef);
+        const MCSymbolRefExpr &SRE = cast<MCSymbolRefExpr>(*Val);
----------------
Add an assert message


https://reviews.llvm.org/D41610