[PATCH] D41849: Make internal/private GVs implicitly dso_local

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola created this revision.
espindola added reviewers: rnk, sfertile.
Herald added subscribers: hiraditya, eraman, nhaehnle, mehdi_amini.

While updating the tests for https://reviews.llvm.org/D41318 I noticed that:

- There are *a lot* of tests to update.
- Many of the updates are redundant.

They are redundant because a GV is "obviously dso_local". This patch starts formalizing that a bit by requiring that internal and private GVs be dso_local too. Since they all are, we don't have to print dso_local to the textual representation, making it a bit more compact and easier to read.


https://reviews.llvm.org/D41849

Files:
  clang/lib/CodeGen/CGOpenMPRuntime.cpp
  clang/test/CodeGenCXX/microsoft-abi-static-initializers.cpp
  clang/test/OpenMP/target_codegen_registration.cpp
  clang/test/OpenMP/target_parallel_codegen_registration.cpp
  clang/test/OpenMP/target_parallel_for_codegen_registration.cpp
  clang/test/OpenMP/target_parallel_for_simd_codegen_registration.cpp
  clang/test/OpenMP/target_simd_codegen_registration.cpp
  clang/test/OpenMP/target_teams_codegen_registration.cpp
  clang/test/OpenMP/target_teams_distribute_codegen_registration.cpp
  clang/test/OpenMP/target_teams_distribute_simd_codegen_registration.cpp
  llvm/include/llvm/IR/GlobalValue.h
  llvm/lib/AsmParser/LLParser.cpp
  llvm/lib/IR/AsmWriter.cpp
  llvm/lib/IR/Verifier.cpp
  llvm/lib/Transforms/Coroutines/CoroSplit.cpp
  llvm/lib/Transforms/IPO/GlobalOpt.cpp
  llvm/test/Bitcode/thinlto-function-summary-refgraph.ll
  llvm/test/Bitcode/thinlto-summary-linkage-types.ll
  llvm/test/Bitcode/thinlto-summary-section.ll
  llvm/test/CodeGen/AMDGPU/enqueue-kernel.ll
  llvm/test/LTO/Resolution/X86/comdat.ll
  llvm/test/Linker/funcimport.ll
  llvm/test/Other/extract.ll
  llvm/test/ThinLTO/X86/alias_import.ll
  llvm/test/ThinLTO/X86/deadstrip.ll
  llvm/test/ThinLTO/X86/export.ll
  llvm/test/ThinLTO/X86/funcimport.ll
  llvm/test/ThinLTO/X86/internalize.ll
  llvm/test/ThinLTO/X86/local_name_conflict.ll
  llvm/test/ThinLTO/X86/referenced_by_constant.ll
  llvm/test/Transforms/FunctionImport/funcimport.ll
  llvm/test/Transforms/ThinLTOBitcodeWriter/comdat.ll
  llvm/test/Transforms/ThinLTOBitcodeWriter/split-internal1.ll
  llvm/test/Transforms/ThinLTOBitcodeWriter/split-internal2.ll
  llvm/test/Transforms/ThinLTOBitcodeWriter/split-vfunc-internal.ll
  llvm/test/Transforms/WholeProgramDevirt/export-single-impl.ll
  llvm/test/tools/gold/X86/coff.ll
  llvm/test/tools/gold/X86/emit-llvm.ll
  llvm/test/tools/gold/X86/global_with_section.ll
  llvm/test/tools/llvm-split/internal.ll
  llvm/test/tools/llvm-split/preserve-locals.ll
  llvm/test/tools/llvm-split/scc-alias.ll
  llvm/test/tools/llvm-split/scc-callchain.ll
  llvm/test/tools/llvm-split/scc-comdat.ll
  llvm/test/tools/llvm-split/scc-constants.ll
  llvm/test/tools/llvm-split/scc-cycle.ll
  llvm/test/tools/llvm-split/scc-global2global.ll
  llvm/test/tools/llvm-split/unnamed.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41849.129026.patch
Type: text/x-patch
Size: 43828 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180109/889c000b/attachment.bin>