[PATCH] D41619: [llvm-objcopy] Use physical instead of virtual address when aligning and placing sections in binary

Owen Shaw via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 8 18:26:09 PST 2018


owenpshaw added a comment.

If I ignore alignment for binary output and offset segments based on their distance from the lowest PAddr, a few tests break.  I think the tests need to change, but looking for other opinions before proceeding.

basic-align-copy.test - Uses binary output in the test.  Should it change to using elf output?  Or was it intended to test binary alignment, which we're now changing?

two-seg-remove-end.test, two-seg-remove-first.test, two-seg-remove-third-sec.test - All use binary output, but define two segments with identical PAddr, so they're output on top of each other using this new offset logic.   Do we actually want to test identical PAddrs, or is that just an oversight in the test that didn't matter before?  Should these tests use binary output, or change to elf?


https://reviews.llvm.org/D41619





More information about the llvm-commits mailing list