[PATCH] D41474: Fix a crash in lazy loading of Metadata in ThinLTO

[Sunil Srivastava via Phabricator via llvm-commits]

Sunil_Srivastava updated this revision to Diff 129016.
Sunil_Srivastava added a comment.

I have trimmed the .ll test somewhat, but I am not sure what is the exact structure that is leading to this error.

The error seems to be related to the limitation (2) mentioned in r291027 for function level, and the fix is along the lines of MetadataLoaderImpl::parseMetadats for the global level, i.e, call resolveForwardRefsAndPlaceholders().

I will be happy to hear any suggestion about where to look for more info on this mechanism and how to proceed.


https://reviews.llvm.org/D41474

Files:
  lib/Bitcode/Reader/BitcodeReader.cpp
  lib/Bitcode/Reader/MetadataLoader.cpp
  lib/Bitcode/Reader/MetadataLoader.h
  test/ThinLTO/X86/Inputs/pr35472-b.ll
  test/ThinLTO/X86/pr35472-a.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41474.129016.patch
Type: text/x-patch
Size: 11235 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180109/aabec543/attachment.bin>