[PATCH] D41728: [TableGen][AsmMatcherEmitter] Remove boolean 'Hack' parameter

Ana Pazos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 8 15:45:48 PST 2018


apazos added a comment.

Hi Sander, sorry for the name confusion.
The callers of validate() skip the instruction in one case, but not in the other. So you are trying to say the message is for the case it is skipped.
What is your alias test case? In my case the AsmString has repeated operands, but the result instruction it maps to is defined with tied operands.
Anyways, this change looks fine for me, if you want to move to validate/merge.


https://reviews.llvm.org/D41728





More information about the llvm-commits mailing list