[PATCH] D41286: [InstCombine] Missed optimization in math expression: sin(x) / cos(x) => tan(x)

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 8 15:43:38 PST 2018


davide added a comment.

In https://reviews.llvm.org/D41286#970372, @spatel wrote:

> In https://reviews.llvm.org/D41286#970343, @davide wrote:
>
> > log(pow(x, y)) -> y*log(x)
>
>
> How is this relevant? Log is only defined for positive numbers, while sin/cos/tan are valid across all numerical inputs.


My point is that fast-math implications can be non-trivial.


https://reviews.llvm.org/D41286





More information about the llvm-commits mailing list