[PATCH] D41286: [InstCombine] Missed optimization in math expression: sin(x) / cos(x) => tan(x)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added subscribers: efriedma, andrew.w.kaylor.
spatel added a comment.

In https://reviews.llvm.org/D41286#970343, @davide wrote:

> log(pow(x, y)) -> y*log(x)


How is this relevant? Log is only defined for positive numbers, while sin/cos/tan are valid across all numerical inputs.

I don't think there's anything I more I can say here; sorry @Quolyk , I tried.  If @hfinkel , @efriedma , @andrew.w.kaylor or anyone else would like to comment that would be great.


https://reviews.llvm.org/D41286