[PATCH] D41687: [llvm-objcopy] Add support for input types and the -I and -B flags

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich updated this revision to Diff 128987.
jakehehrlich added a comment.

1. Removed comment and include for StringSaver stuff
2. Tweaked test to show that stemming and removing of alpha numeric characters exists

Adding ".bin" isn't really ideal. It means that ".tmp" winds up in the stemmed file name but that extension probably isn't something we should relay on.  It turns out (via a means we definitively shouldn't rely on) that the replacement of alpha numeric characters was already being tested because binary-input.test was the stem. I made this explicit in the test so that even if the test file's name changes the test will still test the appropriate things. I add ".bin" as the extension instead of ".tmp". This also shows more explicitly that stemming works correctly.


Repository:
  rL LLVM

https://reviews.llvm.org/D41687

Files:
  test/tools/llvm-objcopy/binary-input-archs.test
  test/tools/llvm-objcopy/binary-input-test.bin
  test/tools/llvm-objcopy/binary-input.test
  tools/llvm-objcopy/Object.cpp
  tools/llvm-objcopy/Object.h
  tools/llvm-objcopy/llvm-objcopy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41687.128987.patch
Type: text/x-patch
Size: 22380 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180108/aec86ec9/attachment.bin>