[PATCH] D41776: [lit] Implement "-r" option for builtin "diff" command + a test using that.

Mon Jan 8 13:48:22 PST 2018

zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.

This looks good to me.  One minor suggestion is to make sure this works with Python 3.  If you're already confident it does, you don't have to do anything.  But we do have at least one bot running Python 3, and i've been hit with Py3 specific errors before and had to fix it while the bot was broken.  Either way, up to you.  Thanks for working on this!

In https://reviews.llvm.org/D41776#970072, @Dor1s wrote:

> By the way, I'm having some troubles running shtest-shell on Linux. Is there any proper way to run it, or maybe we have a test bot that can do it for me? In the worst case I can try that on Windows, but it would take some extra time...

Someone else will need to answer this one, as I have really no idea :-/  Sorry

https://reviews.llvm.org/D41776