[PATCH] D41832: LLParser: Do not check alloca addr space if the assembly does not contain data layout definition

[Yaxun Liu via Phabricator via llvm-commits]

yaxunl added inline comments.


================
Comment at: include/llvm/IR/Verifier.h:101
+                  bool *BrokenDebugInfo = nullptr,
+                  bool CheckAllocaAddrSpace = true);
 
----------------
arsenm wrote:
> I'm not sure I understand why this option is needed or to UpgradeDebugInfo. I would expect the datalayout to be set already by the time any verification is done
LLParser calls UpgradeDebugInfo, which calls verifyModule. At this point the datalayout has not been set yet. llc sets datalayout by target after parsing the IR.


https://reviews.llvm.org/D41832