[PATCH] D41827: [DEBUG] Initial adaptation of NVPTX target for debug info emission.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 8 12:59:28 PST 2018


ABataev added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:272
+  MCSymbol *LineTableStartSym;
+  if (Asm->getObjFileLowering().getTargetTriple().isNVPTX()) {
+    LineTableStartSym = TLOF.getDwarfLineSection()->getBeginSymbol();
----------------
aprantl wrote:
> aprantl wrote:
> > We usually don't "embrace" single lines.
> I find it odd to query for a specific backend. Could we query for a feature in the backend instead?
There are 2 substatements - 1 is single line and another one is 2-line. They both must be enclosed in braces.


https://reviews.llvm.org/D41827





More information about the llvm-commits mailing list