[PATCH] D41832: LLParser: Do not check alloca addr space if the assembly does not contain data layout definition

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/AsmParser/LLParser.cpp:6181-6185
+    if (AS != AddrSpace) {
+      // TODO: In the future it should be possible to specify addrspace
+      // per-alloca.
+      return Error(ASLoc, "address space must match datalayout");
+    }
----------------
The idea was to remove this check from the parser entirely


================
Comment at: lib/IR/Verifier.cpp:3210
+             PTy->getAddressSpace() == DL.getAllocaAddrSpace(),
+         "Allocation instruction pointer not in the stack address space!", &AI);
   Assert(AI.getAllocatedType()->isSized(&Visited),
----------------
s/stack/DataLayout alloca/


https://reviews.llvm.org/D41832