[PATCH] D39869: [Inliner] Inline through indirect call sites having !callees metadata

Matthew Simpson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 8 11:26:51 PST 2018


mssimpso added a comment.

In https://reviews.llvm.org/D39869#969989, @davidxl wrote:

> I think 'tryToPromote' method should be moved to the indirect call promotion pass so that the callback to inline cost/benefit is exposed there (a more general cost/benefit model needs to be developed for indirect call promotion).  Initially, I think we can limit the use of the getInlineCost callback to cases where profile data is not available, this will achieve what this patch is doing without affecting existing promotion heuristics.


Thanks for taking a look at this again, David. This makes sense to me -- I'll update the patch shortly.


https://reviews.llvm.org/D39869





More information about the llvm-commits mailing list