[PATCH] D41824: Remove use of private header in LLDB
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 8 09:00:42 PST 2018
dblaikie requested changes to this revision.
dblaikie added a comment.
This revision now requires changes to proceed.
This looks like it's depending on implementation details of LLVM's libSupport (by redeclaring them locally). Best not to do that - can this code be changed to use the public interface of libSupport (the stuff in include/llvm/Support/Regex.h)? Or, if necessary, expand that interface to provide the necessary functionality explicitly in the header.
Repository:
rL LLVM
https://reviews.llvm.org/D41824
More information about the llvm-commits
mailing list