[lld] r321983 - [COFF] Initalize ErrorHandler with CanExitEarly value

Shoaib Meenai via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 7 22:03:12 PST 2018


Andrew (the patch author) requested this be picked to the 6.0 branch. Rui, do you approve?

From: llvm-commits <llvm-commits-bounces at lists.llvm.org> on behalf of Shoaib Meenai via llvm-commits <llvm-commits at lists.llvm.org>
Reply-To: Shoaib Meenai <smeenai at fb.com>
Date: Sunday, January 7, 2018 at 9:59 PM
To: "llvm-commits at lists.llvm.org" <llvm-commits at lists.llvm.org>
Subject: [lld] r321983 - [COFF] Initalize ErrorHandler with CanExitEarly value

Author: smeenai
Date: Sun Jan  7 21:58:36 2018
New Revision: 321983

URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D321983-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=o3_QVufrb5NLYnACh-1P2fkHw7LqwFYpAQ4Q-vPPbxw&s=fk7PeUgmwTUgCBtB68HduWEQUwyoCwjrViVysM5qEYE&e=
Log:
[COFF] Initalize ErrorHandler with CanExitEarly value

Previously, the COFF driver would call exit(1) from the
ErrorHandler in the case of a link error, even if
CanExitEarly=false was specified. Now it initializes
the ErrorHandler in the same way that the ELF driver does.

Patch by Andrew Kelley.

Differential Revision: https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D41803&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=o3_QVufrb5NLYnACh-1P2fkHw7LqwFYpAQ4Q-vPPbxw&s=3qU1avvt0PQHDV8uCN4Hs7B4O8_p5U09hIZ9Q0Qgqso&e=

Modified:
    lld/trunk/COFF/Driver.cpp

Modified: lld/trunk/COFF/Driver.cpp
URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_lld_trunk_COFF_Driver.cpp-3Frev-3D321983-26r1-3D321982-26r2-3D321983-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=o3_QVufrb5NLYnACh-1P2fkHw7LqwFYpAQ4Q-vPPbxw&s=l60EZM4I9sqgjKUJh8vgkT-udkI7kk3KHrTDrSIebv8&e=
==============================================================================
--- lld/trunk/COFF/Driver.cpp (original)
+++ lld/trunk/COFF/Driver.cpp Sun Jan  7 21:58:36 2018
@@ -57,6 +57,7 @@ bool link(ArrayRef<const char *> Args, b
   errorHandler().ErrorLimitExceededMsg =
       "too many errors emitted, stopping now"
       " (use /ERRORLIMIT:0 to see all errors)";
+  errorHandler().ExitEarly = CanExitEarly;
   Config = make<Configuration>();
   Config->Argv = {Args.begin(), Args.end()};
   Config->CanExitEarly = CanExitEarly;


_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=o3_QVufrb5NLYnACh-1P2fkHw7LqwFYpAQ4Q-vPPbxw&s=WKBfYpw8TdyVRbbkrKIIGpjjzjI5UXMZKblXWcQ6Eps&e=

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180108/076cb6ef/attachment.html>


More information about the llvm-commits mailing list