[PATCH] D41436: [X86][AVX512] Enable variable shuffle combining by default on AVX512 targets

Zvi Rackover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 7 13:22:05 PST 2018

zvi added a comment.

In https://reviews.llvm.org/D41436#969513, @RKSimon wrote:

> In https://reviews.llvm.org/D41436#969481, @zvi wrote:
> > Still trying to get hold of a KNL expert that will answer whether KNL should be included. Can we for now conservatively assume no and exclude KNL from this patch just so this patch can make progress? I want to follow-up on updating the AVX2 tests with FastVariableShuffle configurations.
> Isn't that what we have already? Skylake etc all have FeatureFastVariableShuffle enabled, the issue with this patch was whether we should enable it for the avx512 attribute and not just on a per-cpu basis.

Yes, you are right. Then nothing prevents me from updating the tests...



More information about the llvm-commits mailing list