[PATCH] D41803: ldd::COFF: initalize ErrorHandler with CanExitEarly value

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 6 10:31:23 PST 2018


smeenai added subscribers: benhamilton, llvm-commits.
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM.

For future reference, the standard procedure is to add the relevant -commits mailing list (llvm-commits in this case) as a subscriber when uploading the patch, so that a mail gets sent out to the list. Over here the patch is trivial enough that I'm comfortable accepting regardless.

How did you upload this patch, out of curiosity? There are mechanisms in place to automatically add the relevant -commits list as a subscriber now, so I'm wondering why those weren't triggered. CC @benhamilton

Do you have commit access, or do you need me to commit this for you?


https://reviews.llvm.org/D41803





More information about the llvm-commits mailing list