[PATCH] D41801: Fix pretty printing the unspecified param of a variadic function

[Aaron Smith via Phabricator via llvm-commits]

asmith created this revision.
asmith added reviewers: zturner, llvm-commits.

- Fix a bug in PrettyBuiltinDumper that returns "void" as the name for an unspecified builtin type. Since the unspecified param of a variadic function is considered a builtin of unspecified type in PDBs, we set "..." for its name.
  - Provide a way to determine if a PDBSymbolFunc is variadic in PrettyFunctionDumper. PDBSymbolFunc::getArgument() doesn't return the last unspecified-type param, so instead we check the function's signature which has the last param's information.
  - Add a pretty-func-dumper.test to test pretty dumping of variadic functions.


Repository:
  rL LLVM

https://reviews.llvm.org/D41801

Files:
  test/tools/llvm-pdbdump/Inputs/PrettyFuncDumperTest.cpp
  test/tools/llvm-pdbdump/Inputs/PrettyFuncDumperTest.pdb
  test/tools/llvm-pdbdump/pretty-func-dumper.test
  tools/llvm-pdbutil/PrettyBuiltinDumper.cpp
  tools/llvm-pdbutil/PrettyFunctionDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41801.128841.patch
Type: text/x-patch
Size: 3432 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180106/29168683/attachment.bin>