[PATCH] D41300: [ARM] Fix PR35379 - incorrect unwind information when compiling with -Oz

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 5 17:37:13 PST 2018

compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.

Comment at: test/CodeGen/ARM/PR35379.ll:23
+; CHECK-ARM-NEXT: .pad #8
+; CHECK-ARM-NEXT: push {r9, r10, r11, lr}
+; CHECK-ARM:      pop {r2, r3, r11, pc}
Can you add a CHECK-NOT here for the save?  The check next attempts to do that, but explicitly ensuring it doesn’t happen would be better (and makes it much more obvious).

Comment at: test/CodeGen/ARM/PR35379.ll:29
+; CHECK-THM-NEXT: push {r5, r6, r7, lr}
+; CHECK-THM:      pop {r2, r3, r7, pc}
And here


More information about the llvm-commits mailing list