[PATCH] D41741: LowerTypeTests: Add limited support for aliases
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 5 15:59:12 PST 2018
pcc added inline comments.
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:1711
> pcc wrote:
> > Similarly to my comment above, I think this will need to be a RAUW at the point where the alias is created in case the function declaration has any uses in the merged module.
> I don't think it's possible for there to be any uses here since this function declaration is created in the code directly above and can not yet have any uses and none should be generated below (maybe I'm missing something about how such a use would be generated?)
The merged module may contain an ordinary reference to the function in user code (user code will appear in the merged module if it was compiled with full LTO or if it does not export any symbols). In that case we would fail the if condition on line 1654 above and reuse the existing function.
More information about the llvm-commits