[PATCH] D41758: [PowerPC] Fix assertion due to assuming a type is simple.
Nemanja Ivanovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 5 14:12:18 PST 2018
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
OK, I don't think there's an issue with this - if the vector just happens to be wider, we'll end up needing more of the respective instructions, but it won't turn anything into a library call that wouldn't be a library call otherwise.
Comment at: lib/Target/PowerPC/PPCCTRLoops.cpp:407
+ EVT EVTy = TLI->getValueType(*DL, CI->getArgOperand(0)->getType(),
Nit: I imagine it was probably clang-format that formatted this so, but I would say that putting the entire initialization expression on a separate line is probably more readable.
More information about the llvm-commits