[PATCH] D41701: [DAG] Teach BaseIndexOffset to correctly handle with indexed operations

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 5 11:46:50 PST 2018

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.


Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:13360
       int64_t LdOffset = 0;
       if (LdBasePtr.getBase().getNode()) {
         // The base ptr must be the same.
niravd wrote:
> efriedma wrote:
> > Does this null check still work properly given that BaseIndexOffset::match can return a null base?
> The indexed check @ line 13350 precludes the new case from happening here. 
Oh, I see.


More information about the llvm-commits mailing list