[PATCH] D41701: [DAG] Teach BaseIndexOffset to correctly handle with indexed operations

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 5 11:02:51 PST 2018

efriedma added inline comments.

Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:13360
       int64_t LdOffset = 0;
       if (LdBasePtr.getBase().getNode()) {
         // The base ptr must be the same.
Does this null check still work properly given that BaseIndexOffset::match can return a null base?


More information about the llvm-commits mailing list