[PATCH] D41776: [lit] Implement "-r" option for builtin "diff" command + a test using that.

Max Moroz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 5 10:56:11 PST 2018


Dor1s added a comment.

In https://reviews.llvm.org/D41776#968593, @vsk wrote:

> I haven't looked too closely, but I think this test might fail:
>
>   RUN: mkdir -p %t/A %t/B
>   RUN: touch %t/A/only_in_a %t/B/only_in_b
>   RUN: not diff -r %t/A %t/B
>
>
> If there are tests for lit itself, it might be useful to check this one in.


That's a great point! I should add names for non empty files as well! Also will look for TestRunner tests, thanks Vedant!


https://reviews.llvm.org/D41776





More information about the llvm-commits mailing list