[PATCH] D41723: Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target Injection", and is one of the two halves to Spectre..

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 5 09:01:10 PST 2018

Rui Ueyama <ruiu at google.com> writes:

>> > +template <class ELFT>
>> > +void Retpoline<ELFT>::writeGotPlt(uint8_t *Buf, const Symbol &S) const
>> {
>> > +  write32le(Buf, S.getPltVA() + 21);
>> Add a comment about where the 21 is from.
> It's now 16, and I think the comment isn't needed here because it would be
> a copy-n-paste of the previous comment for X86<ELFT>::writeGotPlt.

How about

// See comments in X86::writeGotPlt.

Like what we have in X86_64<ELFT>::writeGotPlt?


More information about the llvm-commits mailing list