[PATCH] D39912: AMDGPU/SI: Implement d16 support for image intrinsics

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 5 08:48:36 PST 2018

cfang marked 2 inline comments as done.
cfang added inline comments.

Comment at: lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4134
   {"lwe",     AMDGPUOperand::ImmTyLWE,   true, nullptr},
+  {"d16",     AMDGPUOperand::ImmTyD16,   true, nullptr},
   {"dmask",   AMDGPUOperand::ImmTyDMask, false, nullptr},
arsenm wrote:
> It's part of the asm string, so I don't think you need this?
Thanks. Will remove this unnecessary part.

Comment at: lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp:220-223
+void AMDGPUInstPrinter::printD16(const MCInst *MI, unsigned OpNo,
+                                 const MCSubtargetInfo &STI, raw_ostream &O) {
+  printNamedBit(MI, OpNo, O, "d16");
arsenm wrote:
> You shouldn't need this? The d16 string is hardcoded into the asm string?
Yes, this is no longer needed.


More information about the llvm-commits mailing list