[PATCH] D41762: [DWARF] Incorrect prologue end line record.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Is this an X86-only problem or is this a fix for a general problem on X86 only?



================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1172
+  // If the instruction is part of the function frame setup code, do not emit
+  // any line record, as there is no correspondence with any user code.
+  if (MI->isMetaInstruction() || MI->getFlag(MachineInstr::FrameSetup))
----------------
Can you explain why this is necessary / convince me that this is also true for shrink-wrapped code? I could imagine that for shrink-wrapped code, where the frame setup is sunk to the latest possible point it would still be useful to know accurate line numbers for code before the frame setup.


Repository:
  rL LLVM

https://reviews.llvm.org/D41762