[PATCH] D41293: [DAG] Improve Dependency analysis when doing multi-node Instruction Selection
Nirav Dave via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 5 08:42:37 PST 2018
niravd added inline comments.
================
Comment at: llvm/test/CodeGen/X86/2012-01-16-mfence-nosse-flags.ll:17
; CHECK: lock orl {{.*}}, (%esp)
-; CHECK-NEXT: testl [[REG:%e[a-z]+]], [[REG]]
+; CHECK-NEXT: cmpl $0, [[REG:%e[a-z]+]]
----------------
craig.topper wrote:
> Why did we fail to use testl here now?
ISel now can merge the load with the compare operation. We later split it in a call to unfoldMemoryOperand but we only do the check to covert compares back to tests in the MI verstion not the DAG version that's being called.
https://reviews.llvm.org/D41293
More information about the llvm-commits
mailing list