[PATCH] D39910: [ARM] Issue an eror when non-general-purpose registers used in address operands (alternative)

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 5 03:16:25 PST 2018

chill added a comment.

In https://reviews.llvm.org/D39910#968243, @chandlerc wrote:

> In https://reviews.llvm.org/D39910#968198, @olista01 wrote:
> > I approved this patch back in November.
> Just as an FYI, Phab won't send an email to let folks know about this unless you actually write something in the comment box.
> When marking patches as approved, try to always write "LGTM" or something in the message.

chandlerc, thanks. I got all the emails, and was well aware about the status of the review at all time, just wasn't sure what is the proper way to proceed when having conflicting reviews.


More information about the llvm-commits mailing list