[PATCH] D41723: Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target Injection", and is one of the two halves to Spectre..

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 4 18:08:18 PST 2018

chandlerc added a comment.

In https://reviews.llvm.org/D41723#967861, @ruiu wrote:

> Chandler,
> Please apply https://reviews.llvm.org/D41744 to this patch. It includes the following changes:
> 1. xchg is replaced with mov/pop instructions
> 2. x86-64 lazy PLT relocation target is now aligned to 16 byte
> 3. the x86-64 PLT header for lazy PLT resolution is shrunk from 48 bytes to 32 bytes (which became possible by utilizing the space made by (2))

Done, and awesome!

Reid, do you want me to adjust the code for the 32-bit _push thunk?


More information about the llvm-commits mailing list