[PATCH] D41734: [DebugInfo][PDB] Fix too many FPM blocks being written in some cases

Colden Cullen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 4 13:31:01 PST 2018


colden added a comment.

OOOOH That makes so much sense. I was wondering how you could have 2 FPMs at the start but only one every stride after that, but never connected that to this...

I think that's probably close, but wouldn't that only allocate an extra FPM at the end of the stream? Shouldn't we increment the block count by 2 whenever adding a new in-stride FPM? Presumably it's already adding 1 somewhere.


Repository:
  rL LLVM

https://reviews.llvm.org/D41734





More information about the llvm-commits mailing list