[PATCH] D41723: Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target Injection", and is one of the two halves to Spectre..

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: llvm/lib/CodeGen/IndirectBrExpandPass.cpp:161
+
+      int BBIndex = InsertResult.first->second;
+      if (BBIndex == 0)
----------------
chandlerc wrote:
> majnemer wrote:
> > I would think this should also agree with BBToIndex.
> Or should BBToIndex just use an 'int'?
Either way works for me.


https://reviews.llvm.org/D41723