[PATCH] D41714: [x86, MemCmpExpansion] allow 2 pairs of loads per block (PR33325)

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 4 04:51:24 PST 2018

courbet added a comment.

Great! One minor comment.

Comment at: test/Transforms/ExpandMemCmp/X86/memcmp.ll:3
 ; RUN: opt -S -expandmemcmp -mtriple=i686-unknown-unknown   -data-layout=e-m:o-p:32:32-f64:32:64-f80:128-n8:16:32-S128 < %s | FileCheck %s --check-prefix=ALL --check-prefix=X32
 ; RUN: opt -S -expandmemcmp -mtriple=x86_64-unknown-unknown -data-layout=e-m:o-i64:64-f80:128-n8:16:32:64-S128         < %s | FileCheck %s --check-prefix=ALL --check-prefix=X64
We're losing coverage for the case where we're testing for equality with only one load per block. What about adding a line with:
-memcmp-num-loads-per-block=1 to keep these alive ?


More information about the llvm-commits mailing list