[PATCH] D41453: [GVNHoist] Fix: PR35222 gvn-hoist incorrectly erases load in case of a loop

Aditya Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 22:42:54 PST 2018

hiraditya added a comment.

In https://reviews.llvm.org/D41453#961313, @efriedma wrote:

> There are a bunch of places in GVNHoist which call dominates (as opposed to properlyDominates), and some of them seem dubious.  Are you going to audit them?

I'll audit them, thanks for the comment. If you can point which looks dubious to you, that'd help as well. I'll push this patch as it is and add followup patches if changes are required.


More information about the llvm-commits mailing list