[PATCH] D41672: support phi ranges for machine-level IR

Bob Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 21:10:59 PST 2018


bob.wilson added a comment.

Unfortunately that unit test doesn't work. I didn't notice the problem but the sanitizer bot exposed it. The existing bogus target in MachineInstrTest.cpp is only good enough to create instructions but not sufficient to insert them into basic blocks. The addNodeToList ilist callback dereferences the pointer to the MachineRegisterInfo. Adding MachineRegisterInfo would also require TargetRegisterInfo, and even a minimal implementation of that would be quite complicated. If anyone has a good idea of an alternative, please let me know. In the meantime, I have removed the unit test in r321784.


https://reviews.llvm.org/D41672





More information about the llvm-commits mailing list