[PATCH] D40727: Syndicate duplicate code between CallInst and InvokeInst

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

This looks like a nice cleanup.

Do you think it's worth adding an implementation of classof() etc. to CallableBase which calls llvm_unreachable?



================
Comment at: include/llvm/IR/Instructions.h:1358
+//===----------------------------------------------------------------------===//
+/// Base class for all callable instructions, actually InvokeInst and CallInst
+/// Holds everything related to calling a function, abstracting from the base
----------------
nit: ", actually" -> "(InvokeInst and CallInst)."


Repository:
  rL LLVM

https://reviews.llvm.org/D40727