[PATCH] D41719: [InlineCost] Prevent infinite recursion on function pointers

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 15:03:58 PST 2018


arsenm added a comment.

Needs test



================
Comment at: lib/Analysis/InlineCost.cpp:1262-1263
+      Type *DestTy = CI->getDestTy();
+      if (DestTy->isPointerTy() &&
+          DestTy->getPointerElementType()->isFunctionTy()) 
+        return false;
----------------
I don't think you can rely on the pointee type this way


https://reviews.llvm.org/D41719





More information about the llvm-commits mailing list