[PATCH] D41620: [msan] Intercept sendmmsg, recvmmsg.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 14:19:21 PST 2018

eugenis added inline comments.

Comment at: compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc:2860
+    if (fd >= 0) COMMON_INTERCEPTOR_FD_ACQUIRE(ctx, fd);
+    for (int i = 0; i < res; ++i) {
+      COMMON_INTERCEPTOR_WRITE_RANGE(ctx, &msgvec[i].msg_len,
vitalybuka wrote:
> Do you need to check read first?
>                                                                             sizeof(*msgvec);
You mean before REAL(recvmmsg)? For MSan, that would require than *msgvec is initialized by the caller.

For ASan, that would be desirable, but it does not fit the read/write model of these interceptors.


More information about the llvm-commits mailing list