[PATCH] D40876: AArch64: Fix emergency spillslot being out of reach for large callframes

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 13:50:33 PST 2018

efriedma added inline comments.

Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:213
+  // DefaultSafeSPDisplacement is fine as we only emergency spill GP regs.
+  if (!MFI.isMaxCallFrameSizeComputed() ||
+      MFI.getMaxCallFrameSize() > DefaultSafeSPDisplacement)
gberry wrote:
> efriedma wrote:
> > isMaxCallFrameSizeComputed() is false until after register allocation, right?  That means register allocation will never allocate a value into the frame pointer register.  This needs better comments, and I'm not sure we want to unconditionally reserve the frame pointer register just to fix an obscure bug with very large call frames.
> Part of this change is to call computeMaxCallFrameSize() from finalizeLowering() (called at the end of ISel), so I don't think this is a problem?
Oh, sorry, missed that part.  That's much less scary, then.  The only thing I can think of it might impact is inline asm.  Do we have any testcases with inline asm using the frame pointer as an operand or result?


More information about the llvm-commits mailing list