[PATCH] D41214: [cmake] Fix typo in test/asan/CMakeLists.txt

Azharuddin Mohammed via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 13:19:57 PST 2018


azharudd added a comment.

In https://reviews.llvm.org/D41214#966392, @smeenai wrote:

> The two should be equivalent unless `CMAKE_SYSTEM_VERSION` expands out to a value that's a variable name (which is unlikely, since it should be expanding out to a number), but this is cleaner and more consistent.


Also, if the variable is unset, it messes up the if condition expression and causes as CMake error.


Repository:
  rL LLVM

https://reviews.llvm.org/D41214





More information about the llvm-commits mailing list