[PATCH] D41705: Place undefined globals in .bss instead of .data

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 11:11:50 PST 2018


efriedma added a comment.

Please post diffs with context (see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).

Needs a regression test (probably in test/CodeGen/X86), to show that we are in fact generating the expected code.

Does this do the right thing for constant structs which have some null and some undef members?


https://reviews.llvm.org/D41705





More information about the llvm-commits mailing list