[PATCH] D41446: [TableGen][AsmMatcherEmitter] Generate assembler checks for tied operands

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

Thanks Sander, LGTM, with 3 small comments. Please hold off committing this a couple of days, to give other people some more time to voice concerns.



================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:2934
+  OS << "static bool ";
+  OS << "checkAsmOperandConstraints(const MCInst &Inst,\n";
+  OS << "                           const OperandVector &Operands,\n";
----------------
Can you re-name this to `checkAsmOperandTiedConstraints`?


================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:3639
+    OS << "      if (!checkAsmOperandConstraints(Inst, Operands, Loc)) {\n";
+    OS << "         ErrorInfo = " << (HasMnemonicFirst ? "1" : "SIndex") << ";\n";
+    OS << "         return Match_InvalidTiedOperand;\n";
----------------
3 spaces here?


================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:3721
+    OS << "      if (!checkAsmOperandConstraints(Inst, Operands, Loc)) {\n";
+    OS << "         ErrorInfo = " << (HasMnemonicFirst ? "1" : "SIndex") << ";\n";
+    OS << "         return Match_InvalidTiedOperand;\n";
----------------
3 spaces here?


https://reviews.llvm.org/D41446