[PATCH] D41628: [DAGCombine] Fix for PR35763

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 08:41:00 PST 2018

RKSimon added a comment.

In https://reviews.llvm.org/D41628#965775, @samparker wrote:

> Not simply, the original test case is a bit odd and the bug easily fails to trigger. Any particular reason for not using the original reduced test case?

Just that more complex test cases can sometimes result in the underlying issue it was testing being 'hidden' by future (unrelated) patches, the simpler the test case the better likelihood that we're still testing for the same thing.

Please can you commit pr35763.ll with the trunk's current codegen and then update this patch just to show the codegen diff?


More information about the llvm-commits mailing list