[PATCH] D41700: [RISCV] Refactory the existing CC_RISCV32 function to conform to the CCAssignFn type

Leslie Zhai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 08:29:17 PST 2018

xiangzhai added a comment.

Hi Alex,

Thanks for your review!

> My main concern with this approach is it will fail to work when VarArg support is added (https://reviews.llvm.org/D40805).

I will apply the patch of https://reviews.llvm.org/D40805 and read carefully about it.

> meaning you'd need to make further changes to support a custom CCState (as used in Hexagon, SystemZ, Mips and other backends)

I will learn from other Targets to support a custom `RISCVCCState`.

> I think some more GlobalISel design work needs to be done here really.

My sincere thanks <http://lists.llvm.org/pipermail/llvm-dev/2017-December/thread.html> will goto the developers who taught me a lot :) Thanks for your leading!

Leslie Zhai



More information about the llvm-commits mailing list