[PATCH] D41659: Implementing missing trigonometric optimizations

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 07:49:26 PST 2018

fhahn added a comment.

> In https://reviews.llvm.org/D41659#966397, @cs15btech11041 wrote: 
>  Yes. Thank you for the suggestions. I have updated the diff to incorporate the changes you suggested. And submitted different test case for each optimization in isolation. Hope it has made it easier to review the patch.

I think I wasn't too clear, sorry. I meant splitting up the whole patch into 4 different patches and submitting them as separate reviewss, i.e.  one review only including the code & test for `tan(x)*cos(x)=sin(x)`, one for `sin(x)*cos(x) = sin(2*x)/2` and so on.

This also makes it slightly easier to decide if each transform is beneficial on a case-by-case basis.



More information about the llvm-commits mailing list