[PATCH] D41420: [LV][VPlan] NFC patch to move LoopVectorizationPlanner class out of LoopVectorize.cpp

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 04:14:32 PST 2018


hfinkel requested changes to this revision.
hfinkel added a comment.
This revision now requires changes to proceed.

In https://reviews.llvm.org/D41420#966598, @hfinkel wrote:

> LGTM


Unfortunately, it looks like this triggers a warning, at least in GCC 4.8.5:

  In file included from /src/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:50:0:
  /src/llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h:85:7: warning: ‘llvm::LoopVectorizationPlanner’ has a field ‘llvm::LoopVectorizationPlanner::Legal’ whose type uses the anonymous namespace [enabled by default]
   class LoopVectorizationPlanner {
         ^
  /src/llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h:85:7: warning: ‘llvm::LoopVectorizationPlanner’ has a field ‘llvm::LoopVectorizationPlanner::CM’ whose type uses the anonymous namespace [enabled by default]
   

We should fix this before committing.


https://reviews.llvm.org/D41420





More information about the llvm-commits mailing list